Get markdown working on browse pages #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alishaevn
reviewed
Feb 2, 2024
pages/browse/index.js
Outdated
Comment on lines
51
to
57
| const truncateDescription = (desc = '', maxLength, isOpen) => { | ||
| if (desc.length <= maxLength || isOpen) return { truncated: desc, cutOffIndex: desc.length } | ||
| const lastSpaceIndex = desc.substring(0, maxLength).lastIndexOf(' ') | ||
| const ellipsis = isOpen ? '' : '...' | ||
| return { truncated: desc.slice(0, lastSpaceIndex) + ellipsis, cutOffIndex: lastSpaceIndex } | ||
| } | ||
|
|
There was a problem hiding this comment.
can this get moved to "utils/helpers.js"?
There was a problem hiding this comment.
yes definitely, i just tried putting it back there and it worked! for some reason when i first tried that it didn't want to work for me.. but it was probably some other confounding error
alishaevn
requested changes
Feb 2, 2024
alishaevn
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Gets markdown working on the browse page. Homepage will still use snippets.
Related
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Browse page will use description with markdown
Video: https://share.zight.com/o0uOqZx2Featured services will still use snippet